Skip to content

test: add deterministic QA versioning coverage - #169

Closed
Vittuu wants to merge 6 commits into
alvarorichard:devfrom
Vittuu:codex/qa-e2e-versioning
Closed

test: add deterministic QA versioning coverage#169
Vittuu wants to merge 6 commits into
alvarorichard:devfrom
Vittuu:codex/qa-e2e-versioning

Conversation

@Vittuu

@Vittuu Vittuu commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a deterministic QA/versioning gate for GoAnime so release-critical flows are covered without relying on external providers, mpv, ffmpeg, Discord, or interactive terminals.

What changed

  • Added opt-in E2E tests for CLI help/version, command routing, invalid argument handling, download/upscale parsing, and ffmpeg dependency shims.
  • Added offline handler and workflow tests for playback, anime downloads, movie/TV downloads, update handling, image upscale, and no-CGO tracking behavior.
  • Added small package-level test seams that keep production defaults unchanged while allowing deterministic fakes in tests.
  • Added the deterministic E2E suite to CI and release workflows.
  • Documented the QA E2E versioning gate, PM/QA acceptance criteria, live-source classification rules, and release evidence requirements.

Why

The current PR coverage report showed low patch coverage on composed runtime flows, especially download workflow orchestration. These tests move the release gate from argument parsing only to proving that important commands reach the right subsystems under controlled, repeatable conditions.

Validation

Executed locally on Windows with Go 1.26.2 and CGO_ENABLED=0:

  • go test ./internal/handlers ./internal/download ./internal/tracking -count=1
  • go test -tags e2e ./test/e2e -count=1
  • go test -count=1 ./...
  • go fmt ./...
  • go mod verify
  • go vet ./...
  • go test -tags e2e -count=1 -v ./test/e2e
  • go build -v ./cmd/goanime
  • govulncheck ./...
  • gosec ./...
  • staticcheck ./...
  • golangci-lint run --timeout=15m

Note: local go test -race could not run on this Windows environment because runtime/cgo requires gcc; the GitHub Linux CI/release workflow still runs the race suite.

Codacy and Codecov

@codacy-production

codacy-production Bot commented Apr 30, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 237 complexity · 2 duplication

Metric Results
Complexity 237
Duplication 2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@deepsource-io

deepsource-io Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

DeepSource Code Review

We reviewed changes in e9c2e49...ed234c9 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Go Apr 30, 2026 7:39p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.63158% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.70%. Comparing base (d333714) to head (1119277).
⚠️ Report is 19 commits behind head on dev.

Files with missing lines Patch % Lines
internal/download/workflow.go 36.11% 22 Missing and 1 partial ⚠️
internal/upscaler/video.go 59.09% 6 Missing and 3 partials ⚠️
internal/handlers/playback.go 84.61% 2 Missing ⚠️
internal/handlers/download.go 50.00% 0 Missing and 1 partial ⚠️
internal/handlers/upscale.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #169      +/-   ##
==========================================
+ Coverage   24.18%   26.70%   +2.52%     
==========================================
  Files          93       90       -3     
  Lines       21097    21515     +418     
==========================================
+ Hits         5102     5746     +644     
+ Misses      15412    15110     -302     
- Partials      583      659      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Vittuu
Vittuu force-pushed the codex/qa-e2e-versioning branch from 1119277 to ed234c9 Compare April 30, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants